Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server-side printers to our APIs #1730

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add server-side printers to our APIs #1730

merged 2 commits into from
Feb 19, 2024

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Feb 15, 2024 •
edited
Loading

Description of your changes:
This PR defines server-side printing for our APIs and extends ScyllaCluster status with aggregated fields needed for server-side printers or generally assessing the status when there are multiple racks.

(This is long overdue, but I got tired of searching all the conditions manually to find the aggregated ones.)

Which issue is resolved by this Pull Request:
Resolves #1191

Before

NAME                                     AGE
nodeconfig.scylla.scylladb.com/cluster   21d

NAME                                       AGE
scyllacluster.scylla.scylladb.com/scylla   2d6h

NAME                                             AGE
scylladbmonitoring.scylla.scylladb.com/example   91m

NAME                                               AGE
scyllaoperatorconfig.scylla.scylladb.com/cluster   21d

After

NAME                                     AGE
nodeconfig.scylla.scylladb.com/cluster   21d

NAME                                       READY   MEMBERS   RACKS   AVAILABLE   PROGRESSING   DEGRADED   AGE
scyllacluster.scylla.scylladb.com/scylla   5       5         3       True        False         False      3d

NAME                                             AVAILABLE   PROGRESSING   DEGRADED   AGE
scylladbmonitoring.scylla.scylladb.com/example   True        False         False      19h

NAME                                               AGE
scyllaoperatorconfig.scylla.scylladb.com/cluster   21d

scyllaoperatorconfig doesn't have a status to show
nodeconfig needs #1557 first

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 15, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2024
@tnozicka tnozicka mentioned this pull request Feb 15, 2024
Closed
@tnozicka tnozicka changed the title Add server-side printers to our APIs [WIP] Add server-side printers to our APIs Feb 15, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@tnozicka tnozicka changed the title [WIP] Add server-side printers to our APIs Add server-side printers to our APIs Feb 16, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2024
@tnozicka tnozicka force-pushed the printers branch 3 times, most recently from 5860307 to b289f52 Compare February 16, 2024 08:19
@tnozicka
Copy link
Contributor Author

#1525 (comment)
/retest

@tnozicka tnozicka force-pushed the printers branch 2 times, most recently from 05826f5 to ff6f726 Compare February 16, 2024 13:01
zimnx
zimnx approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
great improvement, please extract extra status fields to separate PR as it's a separate feature, worth to be visible in release notes.

@tnozicka tnozicka changed the title Add server-side printers to our APIs [WIP] Add server-side printers to our APIs Feb 19, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@tnozicka
Copy link
Contributor Author

extracted to #1737

@tnozicka tnozicka changed the title [WIP] Add server-side printers to our APIs Add server-side printers to our APIs Feb 19, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@tnozicka tnozicka requested a review from zimnx February 19, 2024 13:43
zimnx
zimnx approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit c51c2bd into scylladb:master Feb 19, 2024
12 checks passed
@tnozicka tnozicka deleted the printers branch February 20, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add server side printers for ScyllaCluster
2 participants
@tnozicka @zimnx